nkXtdMacro - cooldown in macro

Zeno · Jun 30th 2018

I’m looking for a way to add the read back cooldown to a macro, it would be the best if it would read back the cooldown from the skill used in this macro. I couldn’t find the strict macro, only some addons. I’ve already checked MacroCooldowns and ExtraActionBars but they don’t fulfill the task in this case. Macro has got conditions and even if it doesn’t use the skill it still counts the cooldown. nkXtdMacro worked the best here and it would be perfect but it’s got one big disadvantage: it causes micro lags while using skills and not only macros.

The addon itself is not long, so maybe I can find some programmer here, who can catch where the problem is and how to change it. All I know is that after clicking any skill the addon reacts to it and checks all 80 fields on action bars searching for ‘names’ and that causes the micro lags.

Code: nkXtdMacro

nkXtdMacro = {};
nkXtdMacro.AddonName = "nkXtdMacro";
nkXtdMacro.AddonVersion = "v1.0.1";
-- Hook standard function
local orig_ActionButton_Update = ActionButton_Update;
local orig_ActionButton_UpdateCooldown = ActionButton_UpdateCooldown;
local orig_ActionButton_UpdateUsable = ActionButton_UpdateUsable;
function ActionButton_Update(button)
orig_ActionButton_Update(button);
if button ~= nil then
local texture, name, count, locked, wore, continued = GetActionInfo(ActionButton_GetButtonID(button));
if (name ~= nil and name ~= "") then
-- Macro oder Emote
local skillIcon = nkXtdMacro.GetSkillTexture (name);
if skillIcon ~= nil then
local icon = getglobal(button:GetName().."Icon");
icon:SetTexture(skillIcon);
end;
end;
end;
end;
function ActionButton_UpdateCooldown(button)
orig_ActionButton_UpdateCooldown(button);
if button ~= nil then
local texture, name, count, locked, wore, continued = GetActionInfo(ActionButton_GetButtonID(button));
local skillIcon = nkXtdMacro.GetSkillTexture (name);
if name ~= nil then
-- Macro oder Emote
duration, remaining = nkXtdMacro.GetSkillCooldown(name);
if duration ~= nil and remaining ~= nil then
CooldownFrame_SetTime(getglobal(button:GetName().."Cooldown"), duration, remaining);
end;
end;
end;
end
function ActionButton_UpdateUsable(button)
orig_ActionButton_UpdateUsable(button);
if button ~= nil then
local texture, name, count, locked, wore, continued = GetActionInfo(ActionButton_GetButtonID(button));
if name ~= nil then
-- Macro oder Emote
local cooldown, remaining = nkXtdMacro.GetSkillCooldown (name);
if remaining ~= nil then
if ( remaining == 0 ) then
getglobal(button:GetName().."Invalid"):Hide();
else
getglobal(button:GetName().."Invalid"):Show();
end;
end;
end;
end;
end
nkXtdMacro.GetSkillCooldown = function (name)
for tabNum = 1, 5 do
local numSkills = GetNumSkill(tabNum)
if numSkills then
for skillNum = 1, numSkills do
local skillName, temp1, skillIcon, temp2, skillLVL , temp3, tpNextLvl, temp4, learned = GetSkillDetail(tabNum, skillNum);
if skillName == name then
local cooldown, remaining = GetSkillCooldown (tabNum, skillNum);
return cooldown, remaining;
end;
end;
end;
end;
return nil;
end;
nkXtdMacro.GetSkillTexture = function (name)
for tabNum = 1, 5 do
local numSkills = GetNumSkill(tabNum)
if numSkills then
for skillNum = 1, numSkills do
local skillName, temp1, skillIcon, temp2, skillLVL , temp3, tpNextLvl, temp4, learned = GetSkillDetail(tabNum, skillNum);
if skillName == name then
return skillIcon;
end;
end;
end;
end;
return nil;
end;

Display More

And this is the exact macro that should show the cooldown:

Code: Use Sapping Arrow if the target is not already influenced by Withering Seed or Sapping Arrow debuff.

/script i=1;Buff = false;while UnitDebuff("target", i) ~= nil do if UnitDebuff("target", i) == "Withering Seed" or UnitDebuff("target", i) == "Sapping Arrow" then Buff = true;break;end;i=i+1;end;if (not Buff) then CastSpellByName("Sapping Arrow");end;

Rynak · Jul 5th 2018

I did not fully understand what you want to do - do you want to get the cooldown of one of your skills or the duration of an enemy buff?

For the first part you can use cd, remaining = GetSkillCooldown(page,skill) where cd is the total cooldown, remaining the remaining cooldown, page is the skillbookpage (e.g. 3 for secondary class skills) and skill is the number of the skill in that section (e.g. GetSkillCooldown(3,5) for the "Silence" spell of a Warlock/Mage).

For the second objective you can use UnitDebuffLeftTime("target",i) where you can replace "target" by another UnitID if you want and i is the number of the (de)buff, so you have to iterate over it.

I wrote this without checking and testing it, thats just what I remember. Read more in the wiki.

PS: @Mods: We need a place in the forum for this kind of questions, this does not fit into guides!

Zeno · Jul 6th 2018

Quote from Rynak

I did not fully understand what you want to do - do you want to get the cooldown of one of your skills or the duration of an enemy buff?

I want it to check the cooldown of the given skill and display it on the macro's icon, exactly what the addon nkXtdMacro does. But as I mentioned before, the nkXtdMacro addon causes micro lags while using whichever skill that has global cooldown.

Quote from nkXtdMacro

As a small bonus also the cooldown handling will be applied on the actionbar slot the macro is put on. If the skill it is named after has a CD you'll see the numbers ticking down on the action bar like for the regular skill.

Macro with nkXtdMacro

Rynak · Jul 6th 2018

Quote from Zeno

I want it to check the cooldown of the given skill and display it on the macro's icon, exactly what the addon nkXtdMacro does. But as I mentioned before, the nkXtdMacro addon causes micro lags while using whichever skill that has global cooldown.

I am using the Addon MacroCooldowns for this, you could give it a try.

Zeno · Jul 6th 2018

Quote from Rynak

Quote from Zeno

I want it to check the cooldown of the given skill and display it on the macro's icon, exactly what the addon nkXtdMacro does. But as I mentioned before, the nkXtdMacro addon causes micro lags while using whichever skill that has global cooldown.

I am using the Addon MacroCooldowns for this, you could give it a try.

I’ve already checked MacroCooldowns and ExtraActionBars but they don’t fulfill the task in this case. Macro has got conditions and even if it doesn’t use the skill it still counts the cooldown

nkXtdMacro - cooldown in macro

Diogenes Jul 6th 2018

Diogenes Jul 6th 2018

Sarkas Sep 30th 2018

Novar Apr 23rd 2019

Share

Similar Threads

nkXtdMacro - sczytywanie cooldownu w makro

Tags